[PATCH 3/4] Create separate private key for midispcur cursor bits

Keith Packard keithp at keithp.com
Mon May 10 13:25:16 PDT 2010


On Mon, 10 May 2010 20:05:56 +0300, Tiago Vignatti <tiago.vignatti at nokia.com> wrote:

> Why increase the number of privates for mandatory components on Xorg? I guess
> the idea, which should be stated very loud, is to extensions and drivers only
> use private mechanism.

The mi software cursor code (mipointer, misprite, midispcur) isn't
mandatory for all X servers, and so I don't think it should be given a
pointer in the DIX structure.

> And there's much more here (fix-private-usage branch):
> 
>     root at xeron:~/xserver-real# git grep -E "dixSetPrivate|dixFreePrivates" mi/
>     dix/ hw/xfree86/common/ fb/ composite/ render/ os/ | wc -l
>     61

Yeah, separating out which of these are common to all servers shouldn't be
that hard, then they should be given typed pointers. Does that seems
like cleanup that can happen after the privates have been changed?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100510/ece1e46f/attachment.pgp>


More information about the xorg-devel mailing list