[PATCH 1/4] dix: Update element count in FreeResource*()

[Keith Packard]

On Fri, 7 May 2010 15:43:23 -0400, Kristian Høgsberg <krh at bitplanet.net> wrote:

> Eeek, you're right.  And this is different from the other cases
> because here we don't actually delete the resource which caused
> another resource to be added so we'll end up doing it again.  I don't
> have a good answer... we can leave it non-reentrant (didn't seem to
> cause problems before, even when DRI1 apparently deleted resources
> from the callback), or we can decide that the "add resource in
> callback" case is not allowed.

How about 'changing the resource database before returning FALSE is not
allowed'? Otherwise, this function just returns and doesn't look at the
DB again. All current users (dri, xfixes and xinerama) respect this
requirement.

So, I think we should just leave this function alone.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100507/a76c4a26/attachment.pgp>