[PATCH 10/10] xfree86: remove PCI dependency from InitOutput
Vignatti Tiago (Nokia-D/Helsinki)
tiago.vignatti at nokia.com
Fri May 7 09:06:09 PDT 2010
On Fri, May 07, 2010 at 04:39:40PM +0200, ext Adam Jackson wrote:
> On Fri, 2010-05-07 at 15:44 +0300, Tiago Vignatti wrote:
>
> > +Bool
> > +xf86CallDriverProbe( DriverPtr drv, Bool detect_only )
> > +{
> > + Bool foundScreen = FALSE;
> > +
> > + if ( drv->PciProbe != NULL ) {
> > + if ( xf86DoConfigure && xf86DoConfigurePass1 ) {
> > + assert( detect_only );
> > + foundScreen = xf86PciAddMatchingDev(drv);
> > + }
> > + else {
> > + assert( ! detect_only );
> > + foundScreen = xf86PciProbeDev(drv);
> > + }
> > + }
> > +
> > + if ( ! foundScreen && (drv->Probe != NULL) ) {
> > + xf86Msg( X_WARNING, "Falling back to old probe method for %s\n",
> > + drv->driverName );
> > + foundScreen = (*drv->Probe)( drv, (detect_only) ? PROBE_DETECT
> > + : PROBE_DEFAULT );
> > + }
> > +
> > + return foundScreen;
> > +}
>
> You're missing some indent levels here. In fact most of this patch
> seems bizarrely outdented in places. I think your editor is doing
> something strange.
>
All right. Fixed locally.
Thanks,
Tiago
More information about the xorg-devel
mailing list