[PATCH] clientErrorValue is never used outside dix. Stop importing it.

[Keith Packard]

On Thu,  6 May 2010 13:12:03 -0700, Jamey Sharp <jamey at minilop.net> wrote:


> -/* Various of the DIX function interfaces were not designed to allow
> - * the client->errorValue to be set on BadValue and other errors.
> - * Rather than changing interfaces and breaking untold code we introduce
> - * a new global that dispatch can use.
> - */
> -extern XID clientErrorValue;   /* XXX this is a kludge */

If you look in DIX, this is only used by the colormap code and the gc
code, and the gc code even has the appropriate client pointer already.

I'd say we should just nuke the variable and fix the colormap functions.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100506/269ecd58/attachment.pgp>