[PULL] misc XQuartz fixes
Jeremy Huddleston
jeremyhu at apple.com
Sat May 1 11:07:20 PDT 2010
drawable *is* pWin->drawable.
i put the hunk insid ifdef ROOTLESS per your comment, but I wonder if miPaintwindow should return early in the general case if if is called with an UNDRAWABLE_WINDOW
Sent from my iPhone...
On May 1, 2010, at 2:01, Keith Packard <keithp at keithp.com> wrote:
> On Fri, 30 Apr 2010 16:22:07 -0700, Jeremy Huddleston <jeremyhu at apple.com> wrote:
>
>> if (pWin->drawable->type == UNDRAWABLE_WINDOW)
>> return;
>
> Ok, now I'm confused. The patch I see in your tree looks like this:
>
> @@ -552,6 +552,9 @@ miPaintWindow(WindowPtr pWin, RegionPtr prgn, int what)
> DrawablePtr drawable = &pWin->drawable;
>
> #ifdef ROOTLESS
> + if(!drawable || drawable->type == UNDRAWABLE_WINDOW)
> + return;
> +
> if(IsFramedWindow(pWin)) {
> RootlessStartDrawing(pWin);
> RootlessDamageRegion(pWin, prgn);
>
> Are you talking about some other patch?
>
> --
> keith.packard at intel.com
More information about the xorg-devel
mailing list