[PATCH v2] jhbuildrc: Make configuration and usage easier

Dirk Wallenstein halsmit at t-online.de
Sat May 1 00:14:55 PDT 2010


On Fri, Apr 30, 2010 at 11:33:02AM -0700, Dan Nicholson wrote:
> On Fri, Apr 30, 2010 at 1:13 AM, Dirk Wallenstein <halsmit at t-online.de> wrote:
> > This adds extensive documentation and examples for the most important
> > configuration variables of jhbuild. Additionally this allows to specify
> > paths with a leading tilde, and ensures that the paths are absolute
> > otherwise.
> >
> > Signed-off-by: Dirk Wallenstein <halsmit at t-online.de>
> 
> Wow, a lot of information there I wasn't aware of. I didn't test it,
> but it looks good. I guess the expected flow is that you download
> http://cgit.freedesktop.org/xorg/util/modular/plain/jhbuildrc and then
> just run "jhbuild -f jhbuildrc"? That seems very sensible.

Yes, that's all there is.

> > I've defaulted to the URL for the moduleset, because it seems clearer
> > for the completely unedited case.
> > The default for moduleset is 'gnome-*' which is never what we want here.
> > Therefore the value None can be used to select the util/modular clone
> > behavior.
> 
> Yeah, this seems reasonable. The only thing that kind of bothers me is
> that if you cloned modular.git, the default jhbuildrc would not use
> the xorg.modules that is sitting in the same tree. I guess it's a
> tradeoff, though.

Yeah, I don't like it either. The main worry I've had, was that when a
user executes "jhbuild -f jhbuildrc list", it would start a git-clone.
But on a second thought, that can be documented everywhere, and jhbuild
does for example create the prefix in that case, already. I'll revert to
the None default for a v3. Either way, that might not be much of a
problem soon, because I am writing on a proposal for a lightweight
wrapper script -- x-jhbuild, or similar. One benefit would be a
configuration directory, and the moduleset could point there by default.

> Would be good if someone could update the wiki to reflect these changes.
> 
> Acked-by: Dan Nicholson <dbn.lists at gmail.com>
> 
> --
> Dan


More information about the xorg-devel mailing list