[PATCH libXfont] config: remove protection for AS_HELP_STRING for old autoconf

Jeremy Huddleston jeremyhu at apple.com
Sat Mar 27 18:04:59 PDT 2010


Thanks.

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Mar 27, 2010, at 17:53, Gaetan Nadon wrote:

> On Sat, 2010-03-27 at 16:48 -0700, Jeremy Huddleston wrote:
> 
>> I'm confused... what makes it 2.60 instead of 2.58?
>> 
> 
> Sorry about the confusion.
> The 2 changes are not really connected. The de facto lowest common
> denominator
> for all x.org modules is 2.60 (4 years old). As I go along, I update the
> AC_PREREQ statement.
> 
> The m4_ifdef I am removing was put in place in 2005 so that a new (at
> the time) feature
> could be used on the old 2.57 level (8 years old now). 
> 
> I have yet to find a way of saying that clearly. No one uses 2.57
> anymore (automake 1.9 won't even installed)
> but if I write a patch just to bump up the number, then people get
> confused as well as it appears
> to be gratuitous. 
> 
> Thanks
> 
>> On Mar 27, 2010, at 15:01, Gaetan Nadon wrote:
>> 
>>> No longer needed as modules will not configure with 2.57.
>>> AS_HELP_STRING was introduced in 2.58. The minimum level
>>> is now 2.60.
>>> 
>>> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
>>> ---
>>> configure.ac |    4 +---
>>> 1 files changed, 1 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/configure.ac b/configure.ac
>>> index c75a041..852124a 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -20,7 +20,7 @@ dnl  PERFORMANCE OF THIS SOFTWARE.
>>> dnl
>>> dnl Process this file with autoconf to create configure.
>>> 
>>> -AC_PREREQ([2.57])
>>> +AC_PREREQ([2.60])
>>> 
>>> AC_INIT([libXfont],
>>> 	1.4.1,
>>> @@ -57,8 +57,6 @@ PKG_PROG_PKG_CONFIG
>>> AC_CHECK_HEADERS([endian.h poll.h sys/poll.h])
>>> AC_CHECK_FUNCS([poll])
>>> 
>>> -m4_ifdef([AS_HELP_STRING], , [m4_define([AS_HELP_STRING], m4_defn([AC_HELP_STRING]))])
>>> -
>>> #
>>> # select libraries to include
>>> #
>>> -- 
>>> 1.6.0.4
>>> 
>>> _______________________________________________
>>> xorg-devel at lists.x.org: X.Org development
>>> Archives: http://lists.x.org/archives/xorg-devel
>>> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3333 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100327/50761ce8/attachment.bin>


More information about the xorg-devel mailing list