[ANNOUNCE] xorg-server 1.7.99.902

[Dan Nicholson]

On Thu, Mar 25, 2010 at 10:56 AM, Ruediger Oertel <ro at suse.de> wrote:
> On Wednesday 24 March 2010 17:20:24 Dan Nicholson wrote:
>> On Wed, Mar 24, 2010 at 06:05:27AM +0100, Stefan Dirsch wrote:
>> > On Mon, Mar 22, 2010 at 07:59:18AM -0700, Dan Nicholson wrote:
>> > > 2. Make the handling of missing sections from an existing
>> > > configuration behave more like the full autoconfig. In other words, if
>> > > there's a missing Screen section, generate multiple Screen/Device
>> > > pairs with fallbacks. I think this is the correct fix, but I'm not
>> > > that familiar with the autoconfig code so I don't think I could whip
>> > > up a patch that fast.
>> >
>> > I've now attached a patch to
>> >
>> >   https://bugs.freedesktop.org/show_bug.cgi?id=27229
>> >
>> > which does that. It works fine for us.
>>
>> Looks pretty good from my understanding, but I'd like to polish it a bit more
>> before applying it. I'm gonna do the review here since I'm not that familiar
>> with that part of the code.
>>
>> The first thing is that it would be great if this was a git formatted patch
>> with a commit message. But if it's easier to keep it as a separate patch, can
>> you add some information to the patch header? It would also be great if there
>> could be some comments in the code. It looks like multiple Screen sections are
>> being handled, but not really.
>>
>> Now to the patch.
>
> okay, I've reworked the patch again, thanks for all your comments.
> I hope the patch looks better now and is easier to read with the
> inlined comments.

Thanks, it looks a lot nicer.

> however there is an issue with the patch: if you really have more than one
> possible driver, the Xserver will segfault on exit/cleanup in randr/rroutput.c:RROutputDestroyResource
> when cleaning up the resources.
> I've tried several approaches to get the copied screen sections initialized better, but end
> up in nothing but trouble. Any help would be appreciated to clean this last glitch.

Was it doing this before with your first patch? Do you have any
backtrace information?

--
Dan