[PATCH] Use SED set by libtool macros

Dan Nicholson dbn.lists at gmail.com
Wed Mar 24 06:25:53 PDT 2010


On Wed, Mar 24, 2010 at 12:53 AM, Rémi Cardona <remi at gentoo.org> wrote:
> Le 24/03/2010 07:21, Yaakov (Cygwin/X) a écrit :
>> From: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
>>
>> We now use libtool, which calls AC_PROG_SED and sets SED as the path to
>> a fully-functional 'sed' (which may also be called 'gsed' if GNU sed is
>> installed alongside a proprietary version).  Therefore we should respect
>> this value of SED so we are sure to use the correct one.
>
> Then configure should still call AC_PROG_SED explicitely. Relying on
> libtool's macros for that _will_ bite us at some point.

Agreed. I think what libtool's use of AC_PROG_SED tells us is that we
can safely use it too (not like we wouldn't require sed anyway). But,
yeah, this is a good fix.

--
Dan


More information about the xorg-devel mailing list