[PATCH] Do not trap access to timer and keyboard

[Adam Jackson]

On Sat, 2010-03-13 at 02:26 +0100, Samuel Thibault wrote:
> Some VESA BIOSes need to access to them.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault at ens-lyon.org>
> ---
>  hw/xfree86/os-support/hurd/hurd_video.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xfree86/os-support/hurd/hurd_video.c b/hw/xfree86/os-support/hurd/hurd_video.c
> index 4a99db3..e049ceb 100644
> --- a/hw/xfree86/os-support/hurd/hurd_video.c
> +++ b/hw/xfree86/os-support/hurd/hurd_video.c
> @@ -124,8 +124,6 @@ xf86EnableIO()
>  	FatalError("xf86EnableIO: ioperm() failed (%s)\n", strerror(errno));
>  	return FALSE;
>      }
> -    ioperm(0x40,4,0); /* trap access to the timer chip */
> -    ioperm(0x60,4,0); /* trap access to the keyboard controller */
>      return TRUE;
>  }
>  	

I'm not sold on this.  You really do not want to be bashing these ports
directly if the kernel also is.  (Of course, Hurd also doesn't expose
kernel methods for PCI config space access, which means it's racing on
writes to 0xcf8 with the kernel, and just begging to deadlock.)

If this _is_ right, then it almost certainly needs to be done for all
platforms.

Do you have a link to a bug that this is solving?

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100317/c3746801/attachment.pgp>