[PATCH] DRI2: fixup handling of last_swap_target

Florian Mickler florian at mickler.org
Mon Mar 8 17:07:40 PST 2010


On Mon, 8 Mar 2010 11:19:38 -0800
Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> > So we should probable move pPriv->swapsPending++ before the call to...
> > 
> >      ret = (*ds->ScheduleSwap)(client, pDraw, pDestBuffer, pSrcBuffer,
> >                                swap_target, divisor, remainder, func,  
> > data);
> > 
> > ... in DRI2SwapBuffers() and probably add a pPriv->swapsPending--  
> > into the error handling path directly after the call to ds- 
> >  >ScheduleSwap.
> 
> Yep, that's the safer thing to do.  Florian, can you give that a try
> and see if it helps your situation?
> 
> Thanks,

I can't reproduce the hang anymore. I upgraded in the meantime libdrm,
mesa, xf86-video-intel and the xserver to current git head...

i then tried single out what fixed it, but even with everything back to
the versions as of 2nd march, i cannot reproduce it...
this is really weird... on the other hand, it is really cool, because
it works now...

cheers,
Flo


More information about the xorg-devel mailing list