[PATCH] DRI2: make target_sbc signed
Jesse Barnes
jbarnes at virtuousgeek.org
Thu Mar 4 09:51:22 PST 2010
On Thu, 4 Mar 2010 18:32:44 +0100 (CET)
Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
> > Date: Thu, 4 Mar 2010 09:21:50 -0800
> > From: Jesse Barnes <jbarnes at virtuousgeek.org>
> >
> > We need to track invalid targets as well as 0 targets, so just make it
> > unsigned so our comparisons work like they should.
>
> This not only changes signedness, but also makes it 32-bit, at least
> on 32-bit systems. Was that a conscious decision?
Oops, no. The spec wants it to be 64 bit. I'll repost with a correct
commit message and use int64_t or similar.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
More information about the xorg-devel
mailing list