[PATCH 1/2] xfree86: dri2: check for drawable value

[Michel Dänzer]

On Die, 2010-06-29 at 19:00 +0300, Tiago Vignatti wrote: 
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> ---
> I'm not exactly seeing any problem or segfault with this code. I just got this
> issue with the static analyzer.
> 
>  hw/xfree86/dri2/dri2.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
> index f9ba8e7..d4181c9 100644
> --- a/hw/xfree86/dri2/dri2.c
> +++ b/hw/xfree86/dri2/dri2.c
> @@ -734,6 +734,11 @@ Bool
>  DRI2WaitSwap(ClientPtr client, DrawablePtr pDrawable)
>  {
>      DRI2DrawablePtr pPriv = DRI2GetDrawable(pDrawable);
> +    if (pPriv == NULL) {
> +        xf86DrvMsg(pScreen->myNum, X_ERROR,
> +		   "[DRI2] %s: bad drawable\n", __func__);

This allows clients to spam the log file.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer