[PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

[Daniel Stone]

On Mon, Jun 28, 2010 at 06:48:51PM -0700, Keith Packard wrote:
> On Mon, 28 Jun 2010 17:43:28 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > This is really a question of which behavior we want to preserve:
> >   1) clearing of IgnoredClientsWithInput across multiple IgnoreClient
> >   calls
> > or
> >   2) allowing multiple IgnoreClient and AttendClient calls to have any
> >   effect at all except when first ignoring and finally attending
> 
> I think that 2) is what we want -- permitting nesting of ignore/attend
> calls with the client blocked until all of the reasons for suspending
> the client are cleared.
> 
> Can anyone think of a reason to want the other behaviour in
> non-cooperating portions of the server?

Nope, not at all.

> > Here's what the counter patch looks like.  It needs to be matched with
> > a change to my DRI2 patch to unconditionally call AttendClient so the
> > counts match up.
> 
> This looks good to me. I assume the client is allocated with calloc so
> that the count starts out at zero?
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>

With the memset in InitClient noted:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100629/9b8bfc27/attachment.pgp>