[PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

Jesse Barnes jbarnes at virtuousgeek.org
Mon Jun 28 16:59:03 PDT 2010


On Mon, 28 Jun 2010 16:55:30 -0700
Keith Packard <keithp at keithp.com> wrote:

> On Mon, 28 Jun 2010 15:58:46 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> 
> > When ResetCurrentRequest is called, or IgnoreClient is called when a
> > client has input pending, IgnoredClientsWithInput will be set.  However,
> > a subsequent IgnoreClient request will clear the client fd from that fd
> > set, potentially causing the client to hang.
> 
> Sounds like we need a counter for IgnoreClient that leaves the client
> ignored until it gets back to zero.

Yeah, that was another approach I coded up, it worked just as well.
Either way I suppose their could be code depending on the current
behavior, that's what I'm most worried about.

-- 
Jesse Barnes, Intel Open Source Technology Center


More information about the xorg-devel mailing list