[PATCH] XWin: Fix for static libXfont use

[Tiago Vignatti]

On Mon, Jun 28, 2010 at 02:54:37PM +0200, ext Colin Harrison wrote:
> Hi,
> 
> Julien Cristau wrote:
> > What did you test exactly?
> 
> I know this question was not directed to me, but can comment on builds for
> Microsoft Windows.
> AFAIK no compilers for Microsoft Windows can cope properly with weak
> definitions (like those in libXfont).
> There is a lot of discussion on this on the internet, but the
> line-of-least-resistance, is static build libXfont for the xserver.
> In my case (Xming) I therefore don't make a DLL from libXfont and put up
> with binary size increase when the library is linked elsewhere.
> My patch may therefore affect other Cygwin/X uses of libXfont but what else
> needs serverGeneration other than the xserver?
> Fixing the xserver build for Cygwin/X should be the top priority and my
> patch does that (but the Cygwin/X builders may disagree?)
> 

all right, I do agree. So if WIN32 macro means Xming only then I'd give my
review for your patch:

    Acked-by: Tiago Vignatti <tiago.vignatti at nokia.com>


Thank you,
             Tiago