[PATCH] XWin: Fix for static libXfont use

[Julien Cristau]

On Mon, Jun 28, 2010 at 14:20:51 +0300, Tiago Vignatti wrote:

> On Mon, Jun 28, 2010 at 12:48:53PM +0200, ext Colin Harrison wrote:
> > Hi,
> > 
> > All XWin DDX builds use libXfont built static.
> > The following libXfont patch is needed following recent master git changes
> > (use of register_fpe_functions from libXfont in the server)...
> > 
> > --- ./src/util/save_miscutil.c  2010-06-21 16:47:00.000000000 +0100
> > +++ ./src/util/miscutil.c       2010-06-28 11:25:19.000000000 +0100
> > @@ -48,8 +48,10 @@
> > 
> >  extern void BuiltinRegisterFpeFunctions(void);
> > 
> > +#ifndef WIN32
> >  /* make sure everything initializes themselves at least once */
> >  weak long serverGeneration = 1;
> > +#endif
> > 
> 
> can't we just live without serverGeneration then? My quickly compile & test
> approach here worked well when doing it.
> 
What did you test exactly?  The X server has a non-weak serverGeneration
so removing the weak one from libXfont doesn't make a difference there,
but it might for other libXfont users.

Cheers,
Julien