[PATCH] rotation: fix cursor and overlap of one pixel.

Keith Packard keithp at keithp.com
Mon Jun 21 11:16:22 PDT 2010


On Mon, 21 Jun 2010 10:05:08 +1000, Dave Airlie <airlied at gmail.com> wrote:

> This commit reverts that and instead fixes the cursor hotspot translation to
> work like pixman does. We add 0.5 to the cursor vector before translating,
> and floor the value afterwards.

Ooohhh.

This seems reasonable to me as our coordinate system has integers in the
upper left corner of each pixel, so to get from one upper left location
to another, you need to get to the middle of the pixel *before* the
transform instead of afterwards.

Reviewed-by: Keith Packard <keithp at keithp.com>


-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100621/c96a3523/attachment.pgp>


More information about the xorg-devel mailing list