[PATCH 2/2] xfree86: configure: remove vendor and card name matching rules

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Sat Jun 19 03:24:13 PDT 2010


On Fri, Jun 18, 2010 at 09:07:02AM +0200, ext Keith Packard wrote:
> On Thu, 17 Jun 2010 15:22:41 +0300, Tiago Vignatti <tiago.vignatti at nokia.com> wrote:
> 
> > -	DevToConfig[i].GDev.vendor = (char *)VendorName;
> > -	DevToConfig[i].GDev.board = (char *)CardName;
> > -
> 
> You're removing the assignment here
> 
> 
> > -/*    ptr->dev_identifier = DevToConfig[screennum].GDev.identifier;*/
> >      ptr->dev_vendor = DevToConfig[screennum].GDev.vendor;
> >      ptr->dev_board = DevToConfig[screennum].GDev.board;
> 
> But not the use here. Please explain?

thanks for reviewing, Keith! There are two errors in this patch: the wrong
commit description and these last two lines which should be removed as well.

I'm resending this second patch again. Please, refer to the new one.

             Tiago


More information about the xorg-devel mailing list