[PATCH 1/5] libXi: Fix usage of uninitialized value

Julien Cristau jcristau at debian.org
Thu Jun 17 08:48:09 PDT 2010


On Mon, Jun 14, 2010 at 11:47:31 +0300, Pauli Nieminen wrote:

> In error case length of extra data could be uninitialized. This would
> result randomly sized request later in function.
> 
> Signed-off-by: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> ---
>  src/XIProperties.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/XIProperties.c b/src/XIProperties.c
> index 045cc71..0f77e58 100644
> --- a/src/XIProperties.c
> +++ b/src/XIProperties.c
> @@ -150,6 +150,7 @@ XIChangeProperty(Display* dpy, int deviceid, Atom property, Atom type,
>  
>      default:
>  	/* BadValue will be generated */ ;
> +        len = 0;
>      }
>  
>      /* we use data instead of Data32 and friends to avoid Xlib's braindead

Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien


More information about the xorg-devel mailing list