[PATCH] parser/scan.c: use strdup

[Alan Coopersmith]

Matt Turner wrote:
> Found using
> ---
> @@
> expression E;
> identifier i;
> identifier address;
> @@
> 
> - i = malloc(strlen(E) + 1);
> - strcpy(address, E);
> + i = strdup(E);
> ---

Would it be possible to similarly find the other common variant of
	i = malloc(strlen(E) + 1);
	if (i == NULL)
	    /* return 0, FatalError, panic, bail, maybe cleanup first */
	strcpy(address, E);
?

Either way, it's much easier to verify strdup is correct than a
malloc+strcpy pair, so I like it.

> Signed-off-by: Matt Turner <mattst88 at gmail.com>
> ---
>  hw/xfree86/parser/scan.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c
> index 5312143..9f63570 100644
> --- a/hw/xfree86/parser/scan.c
> +++ b/hw/xfree86/parser/scan.c
> @@ -1088,8 +1088,7 @@ void
>  xf86setSection (char *section)
>  {
>  	free(configSection);
> -	configSection = malloc(strlen (section) + 1);
> -	strcpy (configSection, section);
> +	configSection = strdup(section);
>  }
>  
>  /* 

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System