[PATCH 2/2] xfixes: Use list.h macros in tracking hide count

Mikhail Gusarov dottedmag at dottedmag.net
Mon Jun 14 09:30:21 PDT 2010


Twas brillig at 19:16:46 14.06.2010 UTC+03 when tiago.vignatti at nokia.com did gyre and gimble:

 >> All the open coded lists in ther server are there now, and they're
 >> working.  If it's not broken, don't mess with it.  If you come
 >> across an error in an open coded list implementation, that would be
 >> a good reason to port it to list.h.  But otherwise, you're just
 >> almost certainly going to break working code.

 VT(> I disagree with you Kristian.

 VT> Pick any code related with clean-up we had done recently; for
 VT> instance the replacement of the memory allocation function wrappers
 VT> by the C89 ones. We can say that they were "working", but this
 VT> wouldn't be an argument to not remove.

Especially as this clean-up exposed several hidden bugs.

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100614/fb83d1ca/attachment.pgp>


More information about the xorg-devel mailing list