[PATCH 5/5] os: Remove unused dev_tty_from_init variable

Tiago Vignatti tiago.vignatti at nokia.com
Sat Jun 12 05:34:50 PDT 2010


On Fri, Jun 11, 2010 at 08:22:51PM +0200, ext Mikhail Gusarov wrote:
> Signed-off-by: Mikhail Gusarov <dottedmag at dottedmag.net>
> ---
>  os/utils.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/os/utils.c b/os/utils.c
> index 7523d9e..84136bd 100644
> --- a/os/utils.c
> +++ b/os/utils.c
> @@ -205,8 +205,6 @@ int auditTrailLevel = 1;
>  #define HAS_SAVED_IDS_AND_SETEUID
>  #endif
>  
> -static char *dev_tty_from_init = NULL;	/* since we need to parse it anyway */
> -
>  OsSigHandlerPtr
>  OsSignal(int sig, OsSigHandlerPtr handler)
>  {
> @@ -879,8 +877,7 @@ ProcessCommandLine(int argc, char *argv[])
>  	}
>  	else if (strncmp (argv[i], "tty", 3) == 0)
>  	{

and why keep checking for this conditional?

> -	    /* just in case any body is interested */
> -	    dev_tty_from_init = argv[i];
> +            /* init supplies us with this useless information */
>  	}
>  #ifdef XDMCP
>  	else if ((skip = XdmcpOptions(argc, argv, i)) != i)

the rest looks fine:
Reviewed-by: Tiago Vignatti <tiago.vignatti at nokia.com>


             Tiago


More information about the xorg-devel mailing list