[PATCH resend] glxdriswrast bugfix: configure swapgc, not gc.

Dan Nicholson dbn.lists at gmail.com
Wed Jun 9 11:09:03 PDT 2010


On Wed, Jun 9, 2010 at 10:26 AM, Jamey Sharp <jamey at minilop.net> wrote:
> Anybody? I don't want 1.9 to go out with this regression I introduced
> still in it, please.
>
> Jamey
>
> 2010/6/6 Jamey Sharp <jamey at minilop.net>:
>> I got this wrong in e2929db7b737413cf93fbebdf4d15abdfebff05c.
>>
>> Signed-off-by: Jamey Sharp <jamey at minilop.net>
>> Cc: Kristian Høgsberg <krh at bitplanet.net>
>> ---
>> This didn't get any review when I posted it a couple of weeks ago.
>>
>>  glx/glxdriswrast.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c
>> index ac8fd47..54f4440 100644
>> --- a/glx/glxdriswrast.c
>> +++ b/glx/glxdriswrast.c
>> @@ -329,7 +329,7 @@ __glXDRIscreenCreateDrawable(ClientPtr client,
>>     gcvals[0].val = GXcopy;
>>     ChangeGC(NullClient, private->gc, GCFunction, gcvals);
>>     gcvals[1].val = FALSE;
>> -    ChangeGC(NullClient, private->gc, GCFunction | GCGraphicsExposures, gcvals);
>> +    ChangeGC(NullClient, private->swapgc, GCFunction | GCGraphicsExposures, gcvals);
>>
>>     private->driDrawable =
>>        (*driScreen->swrast->createNewDrawable)(driScreen->driScreen,

I'm not familiar with this code, but it looks correct on inspection of
commit e2929db7b737413cf93fbebdf4d15a.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list