performance of pci_device_get_{vendor, device}_name() in X server startup

[Daniel Stone]

On Tue, Jun 08, 2010 at 09:40:55PM -0400, Matt Turner wrote:
> On Tue, Jun 8, 2010 at 9:35 PM, Richard Barnette
> <jrbarnette at chromium.org> wrote:
> > Still, cost/benefit matters here:  Essentially, the justification
> > for all this work is a debug feature (being able to print the information
> > in the log when things go wrong), not a performance enhancement.
> > I'm not yet persuaded that that feature is worth the identified effort.
> 
> I'd still like to hear some opinions from people who do serious
> xserver work, but from my perspective there's nothing wrong with only
> executing this code if -verbose is used. The output of `lspci -vv` is
> already a nearly required piece of any bug report, so I don't think
> we're losing anything here.

Indeed.  We already get a more accurate/useful device/vendor identifier
string from the driver, and we don't need to know/care about non-GPU
devices.

I can see how it would be useful in verbose/error cases, but eh.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100609/237fcf1f/attachment.pgp>