dixSetPrivate regression

[Jeremy Huddleston]

Right.  This was the change that was merged in:

-    if(!dixRequestPrivate(driGCKey, sizeof(DRIGCRec)))
+    if(!dixRegisterPrivateKey(&driGCKeyRec, PRIVATE_GC, sizeof(DRIGCRec)))
        return FALSE;
 
-    if(!dixRequestPrivate(driWrapScreenKey, sizeof(DRIWrapScreenRec)))
+    if(!dixRegisterPrivateKey(&driWrapScreenKeyRec, PRIVATE_WINDOW, sizeof(DRIWrapScreenRec)))
        return FALSE;

What is the correct way to do this with the new API, or was this always broken and we never knew it?

On Jun 6, 2010, at 17:56, Keith Packard wrote:

> On Sun, 06 Jun 2010 17:10:04 -0700, Jeremy Huddleston <jeremyhu at apple.com> wrote:
> 
>> True, but that doesn't solve the problem.
> 
> Oh, you're telling the privates code to allocate space and then you're
> trying to set a pointer to your own space. You get either one or the
> other, not both.
> 
> Note that the 'assert' should be telling you a bit more about what the
> problem is when it crashes.
> 
> -- 
> keith.packard at intel.com
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel