[PATCH 0/8] Getting rid of xstrdup

Alan Coopersmith alan.coopersmith at oracle.com
Sun Jun 6 12:58:22 PDT 2010


Mikhail Gusarov wrote:
> Most of xstrdup invocations in server were superfluous. This patch series gets
> rid of them, keeping ~10 which are harder to reason about.
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

For patches 1-7:
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

For patch 8:  While the change isn't wrong, I'll leave it up to
one of the XKB maintainers to decide if introducing a FatalError()
where there was none before (Xprintf -> XNFprintf) is the right thing
to do.   (Though as we all know, the really right thing long term is
to stop forking xkbcomp, but that's not a two-line change like this
patch.)

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list