[PATCH 4/4] Do not include X11/Xfuncs.h anymore: b{copy, zero, cmp} are not in use

Alan Coopersmith alan.coopersmith at oracle.com
Fri Jun 4 07:05:39 PDT 2010


Mikhail Gusarov wrote:
> Signed-off-by: Mikhail Gusarov <dottedmag at dottedmag.net>
> ---
>  include/misc.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/misc.h b/include/misc.h
> index 62d813e..7eea722 100644
> --- a/include/misc.h
> +++ b/include/misc.h
> @@ -108,7 +108,8 @@ typedef struct _CallbackList *CallbackListPtr; /* also in dix.h */
>  typedef struct _xReq *xReqPtr;
>  
>  #include "os.h" 	/* for ALLOCATE_LOCAL and DEALLOCATE_LOCAL */
> -#include <X11/Xfuncs.h> /* for bcopy, bzero, and bcmp */
> +
> +#include <string.h>
>  
>  #define NullBox ((BoxPtr)0)
>  #define MILLI_PER_MIN (1000 * 60)

Since this is part of the exported SDK headers, are you sure that all the
drivers that include this file will still build?   (At least the ones you
can verify, since there's no way to check the closed source drivers.)

Given that X11/Xfuncs.h can't go away, I'm not sure this change is worth
the effort or risk.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list