[PATCH] composite: set oldpixmap to NULL if we fail to realloc the pixmap.

Keith Packard keithp at keithp.com
Wed Jun 2 19:09:56 PDT 2010


On Thu,  3 Jun 2010 10:16:19 +1000, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> We don't explicity set the old pixmap to NULL if we fail the realloc, which
> later leads to us dereferencing an uninitialised or stale pointer.

pOldPixmap *should* already be set to null -- any idea which code path
that's not getting set in?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100602/13a429c0/attachment.pgp>


More information about the xorg-devel mailing list