[PATCH v6 1/3] DRI2: add AuthMagic hook for driver side support

Kristian Høgsberg krh at bitplanet.net
Tue Jun 1 05:42:12 PDT 2010


On Mon, May 31, 2010 at 6:22 PM, Owain Ainsworth <zerooa at googlemail.com> wrote:
> On Mon, May 31, 2010 at 12:52:06PM +0300, Pauli Nieminen wrote:
>> From: Tiago Vignatti <tiago.vignatti at nokia.com>
>>
>> With this new hook drmAuthMagic becomes useless and should be deprecated.
>> You might want to implement AuthMagic on driver side instead.
>
> I still don't like the suggestion here.
>
> So you think that every drm-based dri2 supporting driver should be
> changed to have a chunk setting this pointer to drmAuthMagic added?

It's a one-liner in each of the three DRI2 capable drivers.  Not a lot
of work.  And the couple of libdrm calls in DRI2 always stood out a
bit in what could otherwise be a generic, DIX level extension.  So I
think these patches make sense, and once the DDX drivers have picked
up support for this, we'll bump the API and move DRI2 up as a DIX
extension.

Kristian


More information about the xorg-devel mailing list