[PATCH video-intel] simplify Makefile as per-target compilation flags are not needed
Alan Coopersmith
alan.coopersmith at oracle.com
Sat Jul 24 08:56:35 PDT 2010
Chris Wilson wrote:
> On Fri, 23 Jul 2010 19:15:22 -0400, Gaetan Nadon <memsize at videotron.ca> wrote:
>> We then do not need the AM_PROG_CC_C_O to detect compiler who
>> do not accept both -c and -o together.
>>
>> This setup is only needed when the same source is compiled
>> multiple times with different compiler options.
>
> Looks ok, and I don't have plans to break it in the immediate future.
> There used to be a C file shared between i810 and i830, no longer.
>
> Can you add a note explaining the target_CFLAGS to AM_CFLAGS change? Why
> does that need to be coupled to the removal of AM_PROG_CC_C_O or is that
> just accidental?
It's part of the same change - "target_CFLAGS" is what indicates to automake
that the same file needs to be compiled for different targets with different
CFLAGS:
http://sources.redhat.com/automake/automake.html#index-maude_005fCFLAGS-463
AM_CFLAGS indicates the same CFLAGS are used for compiling all C sources in
the directory. Per-target CFLAGS in Makefile.am require AM_PROG_CC_C_O in
configure.ac.
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel
mailing list