[PATCH xserver] Change __FUNCTION__ to __func__

Matthieu Herrb matthieu.herrb at laas.fr
Wed Jul 21 04:23:23 PDT 2010


On Wed, Jul 21, 2010 at 11:27:25AM +0100, Daniel Stone wrote:
> On Wed, Jul 21, 2010 at 07:54:14AM +0200, Matthieu Herrb wrote:
> > On Wed, Jul 21, 2010 at 07:07:29AM +0200, Tomas Carnecky wrote:
> > > On 7/21/10 6:19 AM, Jesse Adkins wrote:
> > > > __func__ is the ISO C99 way of getting the current function name.
> > > 
> > > The xserver only depends on C89, though it does use some C99 some
> > > extensions. The required extensions are documented in doc/c-extensions.
> > > How about adding the dependency on __func__ to the file?
> > > 
> > > Are there any C89-only platforms left which prevent us from switching to
> > > C99?
> > 
> > Yes. 
> 
> I think Matthieu's referring to m68k and VAX on OpenBSD here, which are
> stuck with gcc 2.9x because no-one bothered to do DSO support for them
> in gcc 3.x?

Yes; it's not exactly that but it's a number of OpenBSD platforms
which are stuck with gcc 2.95 for various reasons. 

The most significant one is sparc (the old, pre sun4m models) for
which at least xserver 1.8 still works and is useable to some extent. 

Other legacy hardware platforms (vax, m68k, m88k, alpha) matter less
for xserver, because they generally can't run the X server for various
reasons, or the xserver is so limited that it has not practical use.
But keeping working clients on them is still important to the
OpenBSD project

-- 
Matthieu Herrb


More information about the xorg-devel mailing list