[PATCH] xephyr: Fix crash in initial MapWindow on 24bpp host servers

[Keith Packard]

On Fri, 16 Jul 2010 15:29:01 -0400, Adam Jackson <ajax at redhat.com> wrote:

> Previous code assumed we were always 32bpp, so root window paint walked
> off the end of the XImage and things went boom.

<bikeshed?>

My brain is small today; I looked at this patch and had to go read the
code very carefully as it looks like it just adds an assignment to
fb.bitsPerPixel, so it was hard to see where the above assuption
occurred.

I think it would be nicer if the patch removed the bogus assignments
which are still there.

</bikeshed?>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100718/9e86fca7/attachment.pgp>