[PATCH 1/3] rootless: ROOTLESS_PROTECT_ALPHA is always set, so unifdef it.

Colin Harrison colin.harrison at virgin.net
Thu Jul 15 14:35:03 PDT 2010


Hi,

Just tried the opposite in Xming (i.e. #undef ROOTLESS_PROTECT_ALPHA) and
can't see any difference in rootless modes.
But my tests are probably not good enough and I don't understand the
rootless code deep enough :)
I can't therefore see why the  #if defined(__CYGWIN__) || defined(WIN32)
version has to be different for the #ifdef __APPLE__ one on this. 
Either way the miext/rootless code is unloved, buggy and ugly and
simplifying it may make it easier to handle and fix (thanks Jamey).
So given the choice of ROOTLESS_PROTECT_ALPHA 'in' or 'out'..I'm with 'in',
"the way it has always been" for me, for what that is worth.

Thanks,
Colin Harrison



More information about the xorg-devel mailing list