[PATCH] dix: Reshuffle ScreenRec to pack holes

Jamey Sharp jamey at minilop.net
Tue Jul 13 17:59:26 PDT 2010


On Wed, May 19, 2010 at 11:31 AM, Adam Jackson <ajax at redhat.com> wrote:
> ...This also marks a flags field for future expansion without needing to
> break ABI.

I was just reviewing this again because I wanted to add a flag to
ScreenRec, and I noticed:

> +    unsigned           backingStoreSupport:1;
> +    unsigned           saveUnderSupport:1;

These fields apparently can each have one of three possible values, so
they need two bits each.

I still think the reshuffling is a good idea, though the patch you
posted originally obviously won't apply now.

Jamey


More information about the xorg-devel mailing list