requiring yacc to build xkbcomp

[Dan Nicholson]

On Thu, Jul 8, 2010 at 11:41 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> On Thu, 2010-07-08 at 17:39 +0100, Julien Cristau wrote:
>
> On Thu, Jul  8, 2010 at 12:31:57 -0400, Gaetan Nadon wrote:
>
>> On Thu, 2010-07-08 at 16:28 +0100, Julien Cristau wrote:
>>
>> > When building from tarball, yacc isn't needed because xkbparse.c is
>> > shipped.
>> >
>>
>> I don't see how this is related to the patch. The AC_PROG_YACC behavior
>> is wrong, the patch attempts
>> to restore the design intent (maybe we were both wrong there).
>>
> The patch makes my build fail when I don't have bison installed in the
> chroot, while it built fine before.
>
> Your expectations are correct, one should be able to build a tarball without
> yacc.
> Peter's expectations are also correct, the configuration should fail if a
> development tool
> is missing.
>
> Automake can handle both scenarios due the dependencies checking. It has
> also added
> the maintainer clean concept to prevent accidental deletion of files
> generated by "special tools"
> not available at build time.
>
> Autoconf however does not have support for both scenarios. At configuration
> time, only
> the presence and/or capabilities is checked, not whether it is needed or
> not.
>
> Currently, it appeared to be working because of a bug, where by a missing
> yacc was never detected.
> I'll propose a patch to correctly handle this situation.

Just add an automake dependency on whether $srcdir/src/xkbparse.c (not
sure of the path) is there. Take a look at the libXI source for how
the man pages are handled.

--
Dan