[PATCH libX11 0/4] Overhaul makekeys.c

[Daniel Stone]

On Thu, Jul 08, 2010 at 07:58:29AM -0700, Alan Coopersmith wrote:
> Daniel Stone wrote:
> > I've attached a patchset which cleans up makekeys.c to handle vendor
> > keysyms from XF86keysym.h, Sunkeysym.h, DECkeysym.h and HPkeysym.h as
> > well as just the core ones from keysymdef.h as well.  This means that we
> > can get rid of XKeySymDB, which saves us a great deal of frustration and
> > drama in remembering to keep it in sync, as well as the time and memory
> > expended in loading and parsing it.
> 
> This allows users/distros to provide a custom XKeysymDB if they want to
> add keys, just no longer distributes/requires one from us upstream, right?
> (Not that we should encourage that, but I'm sure there are those out there
>  who have done this, especially for embedded systems adding custom keysyms
>  for their specific device.)

Yep!

> > This was sponsored by Nokia/Collabora as part of the xkbcommon/make
> > xkbcomp not show up as a huge black mark in the bootchart work.
> 
> Thank them for us.

Will do. :)

> For the series:
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Thanks, will push these with your review on all, and Gaetan's on #1.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100708/ed54a07e/attachment.pgp>