[PATCH] fbdev: fix devPrivates and do not disable xrandr when rotated

Denis 'GNUtoo' Carikli GNUtoo at no-log.org
Wed Jul 7 09:43:46 PDT 2010


> It sounds
> like you just want not to call xf86DisableRandR()??
Yes thanks a lot it works well like this too.
Should I resend the patch?

On Tue, 2010-07-06 at 18:37 +0200, Michel Dänzer wrote:
> On Die, 2010-07-06 at 18:19 +0200, Denis 'GNUtoo' Carikli wrote: 
> > >  Did you test that the DGA video features work correctly with rotation?
> > no I didn't, how can I test it?
> 
> E.g. with git://anongit.freedesktop.org/git/xorg/app/xf86dga .
> 
> I'm pretty sure it can't work though. Why do you (think you) need to
> call FBDevDGAInit()?
I tried the dga xorg application
It does something when not rotated and fails when rotated like this:

root at htcdream ~ # dga 
X Error of failed request:  XF86DGANoDirectVideoMode
  Major opcode of failed request:  130 (XFree86-DGA)
  Minor opcode of failed request:  1 (XF86DGAGetVideoLL)
  Serial number of failed request:  15
  Current serial number in output stream:  15

but the second time I run it I have:
root at htcdream ~ # dga 
1 addr:0x4040c000, width 320, bank size 1048577, depth 16 planes
Relative Motion: 189 71
Button 1 pressed
Relative Motion: 190 72
Relative Motion: 193 73
Relative Motion: 196 75
Relative Motion: 201 77
Relative Motion: 207 80
Relative Motion: 214 82
Relative Motion: 232 88
Relative Motion: 242 90
Relative Motion: 252 92
Relative Motion: 257 94
Relative Motion: 262 95
Relative Motion: 265 95
Relative Motion: 272 96
Relative Motion: 277 97
Relative Motion: 282 98
Relative Motion: 287 98
Relative Motion: 290 99
Relative Motion: 293 99
Relative Motion: 295 100
Relative Motion: 297 100
Relative Motion: 299 101
Relative Motion: 299 102
Relative Motion: 300 102
Relative Motion: 298 103
Relative Motion: 294 103
Relative Motion: 291 103
Button 1 released

And the third time:
# dga 
1 addr:0x4040c000, width 320, bank size 1048577, depth 16 planes

I attached the corresponding log of xorg.conf during the running of the
dga application...

when not rotated it works the first time:
root at htcdream ~ # dga 
1 addr:0x4040c000, width 320, bank size 1048577, depth 16 planes
Relative Motion: 188 189
Button 1 pressed
Relative Motion: 188 190
Relative Motion: 188 191
Relative Motion: 188 192
Relative Motion: 187 194
Relative Motion: 187 196
Relative Motion: 187 198
Relative Motion: 187 199
Relative Motion: 187 200
Relative Motion: 187 202
Relative Motion: 188 203
Relative Motion: 188 204
Button 1 released

but fails the second time:
1 addr:0x4040c000, width 320, bank size 1048577, depth 16 planes

I won't attach the log since the first previous xorg.log already takes
some space.

I looked at mplayer which seem to support dga but I got some failures
both in rotated and non-rotated mode:
# mplayer -vo dga Sintel_Open_Movie_Trailer-HOfdboHvshg.flv  | head -n
100
MPlayer UNKNOWN-4.5.1 (C) 2000-2010 MPlayer Team
154 audio & 340 video codecs

Playing Sintel_Open_Movie_Trailer-HOfdboHvshg.flv.
libavformat file format detected.
[flv @ 0x40db8188]Estimating duration from bitrate, this may be
inaccurate
[lavf] stream 0: video (flv), -vid 0
[lavf] stream 1: audio (mp3), -aid 0
VIDEO:  [FLV1]  400x170  0bpp  24.000 fps  232.1 kbps (28.3 kbyte/s)
Clip info:
duration: 52
starttime: 0
totalduration: 52
width: 400
height: 170
videodatarate: 227
audiodatarate: 59
totaldatarate: 293
framerate: 24
bytelength: 1912749
canseekontime: true
sourcedata: B4A7D0441HH1278238316100781
purl: 
pmsg: 
vo_dga: Mode: depth=15, bpp=16, r=007c00, g=0003e0, b=00001f, native
(-bpp 15)
vo_dga: Mode: depth=16, bpp=16, r=00f800, g=0007e0, b=00001f, native
(-bpp 16)
vo_dga: Mode: depth=24, bpp=24, r=ff0000, g=00ff00, b=0000ff, not
supported (-bpp 24)
vo_dga: Mode: depth=24, bpp=32, r=ff0000, g=00ff00, b=0000ff, not
supported (-bpp 32)
==========================================================================
Opening video decoder: [ffmpeg] FFmpeg's libavcodec codec family
Selected video codec: [ffflv] vfm: ffmpeg (FFmpeg Flash video)
==========================================================================
==========================================================================
Forced audio codec: ffmp3
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
AUDIO: 22050 Hz, 2 ch, s16le, 8.0 kbit/1.13% (ratio: 1000->88200)
Selected audio codec: [ffmp3] afm: ffmpeg (FFmpeg MPEG layer-3 audio)
==========================================================================
AO: [alsa] 22050Hz 2ch s16le (2 bytes per sample)
Starting playback...
Could not find matching colorspace - retrying with -vf scale...
Opening video filter: [scale]
Movie-Aspect is undefined - no prescaling applied.
[swscaler @ 0x40e03f78]No accelerated colorspace conversion found from
yuv420p to rgb565le.
[swscaler @ 0x40e03f78]using unscaled yuv420p -> rgb565le special
converter
VO: [dga] 400x170 => 400x170 BGR 16-bit 
vo_dga: DGA 2.0 available :-) Can switch resolution AND depth!
vo_dga: Selected hardware mode 100000 x 100000 @ 100000 Hz @ depth 16,
bitspp 16.
vo_dga: Video parameters by codec: 400 x 170, depth 16, bitspp 16.
vo_dga: Something is wrong with your DGA. There doesn't seem to be a
         single suitable mode!
         Please file a bug report (see DOCS/HTML/en/bugreports.html)
FATAL: Cannot initialize video driver.
Movie-Aspect is undefined - no prescaling applied.
[swscaler @ 0x40e03f78]No accelerated colorspace conversion found from
yuv420p to rgb565le.
VO: [dga] 400x170 => 400x170 BGR 16-bit 
vo_dga: DGA 2.0 available :-) Can switch resolution AND depth!
vo_dga: Selected hardware mode 100000 x 100000 @ 100000 Hz @ depth 16,
bitspp 16.
vo_dga: Video parameters by codec: 400 x 170, depth 16, bitspp 16.
vo_dga: Something is wrong with your DGA. There doesn't seem to be a
         single suitable mode!
         Please file a bug report (see DOCS/HTML/en/bugreports.html)
FATAL: Cannot initialize video driver.
Movie-Aspect is undefined - no prescaling applied.
[swscaler @ 0x40e03f78]No accelerated colorspace conversion found from
yuv420p to rgb565le.
VO: [dga] 400x170 => 400x170 BGR 16-bit 
vo_dga: DGA 2.0 available :-) Can switch resolution AND depth!
vo_dga: Selected hardware mode 100000 x 100000 @ 100000 Hz @ depth 16,
bitspp 16.
vo_dga: Video parameters by codec: 400 x 170, depth 16, bitspp 16.
vo_dga: Something is wrong with your DGA. There doesn't seem to be a
         single suitable mode!
         Please file a bug report (see DOCS/HTML/en/bugreports.html)

Thanks a lot!!!

Denis.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Xorg.0.log
Type: text/x-log
Size: 128549 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100707/9aee5a06/attachment-0001.bin>


More information about the xorg-devel mailing list