[PATCH video-chips 1/3] config: remove ISA bus code, as support is removed from xserver

Peter Hutterer peter.hutterer at who-t.net
Mon Jul 5 19:14:55 PDT 2010


On Mon, Jul 05, 2010 at 08:07:06PM -0400, Gaetan Nadon wrote:
> On Mon, 2010-07-05 at 14:54 +0300, Tiago Vignatti wrote:
> 
> > understand so much the reason for that). So "remove ISA bus code, as
> > support
> > is removed from xserver" is not the argument. 
> 
> Agreed
> 
> > 
> > On the other hand, we don't have a policy defined to deprecate a given
> > functionality of a driver after a given time or versions. So we could
> > go now
> > and deprecate ISA from there easily.
> 
> 
> The ISA bus support was removed from server end of 2008. I thought
> people would have complained by now if their computer with ISA bus would
> not work any more. Some of them must have upgraded to server 1.6. But
> it's just a guessing game.
> 
> The motivation for this patch is simply for clean-up, not big deal, but
> I have noticed functional maintenance work in this area. Removing dead
> code can save maintenance, if we can be sure it's really dead.
> 
> It would be useful to have an up-to-date PKG_CHECK_MODULES(XORG,
> [xorg-server >= ????] statement in each driver. It would tell developers
> how far back to check for compatibility.

I'd be wary of changing drivers that only see a few patches a year, most of
them build fixes. Fix bugs when reported if you're interested but otherwise
I think your time could be more efficiently spent elsewhere, with drivers
that matter more to users today.

Cheers,
  Peter


More information about the xorg-devel mailing list