[PATCH] Initialize dev privates before using any

[Vignatti Tiago (Nokia-MS/Helsinki)]

On Thu, Jul 01, 2010 at 03:55:01PM +0200, ext Keith Packard wrote:
> On Thu, 1 Jul 2010 16:42:38 +0300, Tiago Vignatti <tiago.vignatti at nokia.com> wrote:
> 
> > 1 PIXMAPs still allocated at reset
> > PIXMAP: 1 objects of 40 bytes = 40 total bytes 0 private allocs
> 
> > TOTAL: 1 objects, 40 bytes, 0 allocs
> >
> > I don't think this is expected, right? If you need some help to track down
> > some possible leaks here just tell me an easy way to do so.
> 
> Yes, you're leaking a pixmap, most likely a screen pixmap as your driver
> isn't freeing it during server reset. I know that at least the intel
> driver still leaks this pixmap. I thought I had posted a patch to fix
> that, if not, here it is:

In my desktop right now I just have two drivers using XAA to test. Both are
leaking this pixmap. 

I don't have time now to keep digging on it but seems that the fix should be
inside XAA, isn't?


> From 4f3397774a48a214755740f846e1eb8995a744bb Mon Sep 17 00:00:00 2001
> From: Keith Packard <keithp at keithp.com>
> Date: Fri, 30 Apr 2010 13:33:14 -0700
> Subject: [PATCH] Destroy screen pixmap on screen close.
> 
> This avoids a memory leak on server reset.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>

It's not applied yet on intel driver. So:

    Acked-by: Tiago Vignatti <tiago.vignatti at nokia.com>


Cheers,
             Tiago