[PATCH] fb: Trim fill to drawable bounds

Chris Wilson chris at chris-wilson.co.uk
Fri Jul 2 09:13:29 PDT 2010


On 02 Jul 2010 17:19:18 +0200, Soeren Sandmann <sandmann at daimi.au.dk> wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Fixes:
> > 
> >   Bug 27313 - random X11 crash (SIGSEGV) when rendering firefox in pixman/intel
> >   https://bugs.freedesktop.org/show_bug.cgi?id=27313
> > 
> > As pixman does not guard against a fill request outside of the buffer,
> > we must be be careful and trim oversized fills.
> 
> Shouldn't this be clipped before it hits fbFill() by the code in fbPolyFillRect()?

AIUI (after grepping the tree to try and understand the clipping a bit
better..), an unclipped Window's fbGetCompositeClip() is the screen bounds and
not the drawable's.
-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the xorg-devel mailing list