[PULL] PointerKey fixes, stuck grab fix

Peter Hutterer peter.hutterer at who-t.net
Thu Jul 1 16:00:43 PDT 2010


Keith,

please pull the fixes below into master. They fix three different cases
where a button or grab may get stuck, leading to an unresponsive desktop.

First commit fixes a stuck grab we could reproduce with mwm. If the client
didn't have ButtonPress selected on the grab mask, the event wasn't
delivered.

The other commits fix up the PointerKey behaviour. A long description is in
 "xkb: merge lockedPtrButtons state from all attached SDs."
short story is that buttons may get locked. We've since discovered that some
clients rely on the PointerKey buttons be released by other devices
(#28808), patch for this is included.

The other patches are comments added and/or removed, nothing exciting.

The following changes since commit 3b3c77b87070ddcdbb2acb114a81628485e7a129:

  configure: don't check xfont always for each server (2010-06-24 13:55:42 -0700)

are available in the git repository at:
  git://people.freedesktop.org/~whot/xserver.git for-keith

Peter Hutterer (7):
      Revert "dix: use the event mask of the grab for TryClientEvents."
      xkb: remove now obsolete comment.
      dix: fix up erroneous error message.
      xkb: Mark switch case fallthrough with comment.
      xkb: merge lockedPtrButtons state from all attached SDs.
      xkb: emulate PointerKeys events only on the master device.
      xkb: release XTEST pointer buttons on physical releases. (#28808)

 dix/devices.c    |    2 +-
 dix/events.c     |   52 ++--------------------------------------------------
 include/xkbsrv.h |    9 +++++++++
 xkb/xkbAccessX.c |   31 ++++++++++++++-----------------
 xkb/xkbActions.c |   23 ++++++++++++++++-------
 xkb/xkbUtils.c   |   26 ++++++++++++++++++++++++++
 6 files changed, 68 insertions(+), 75 deletions(-)


More information about the xorg-devel mailing list