[PATCH] xfree86: get ddx to rebuild correctly

Dan Nicholson dbn.lists at gmail.com
Thu Jul 1 08:51:59 PDT 2010


On Thu, Jul 1, 2010 at 6:15 AM, Tiago Vignatti <tiago.vignatti at nokia.com> wrote:
> Create a dependency in ddx whenever libmain.la and libdix.la change.
>
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> ---
>  hw/xfree86/Makefile.am |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
> index 116113b..295fb47 100644
> --- a/hw/xfree86/Makefile.am
> +++ b/hw/xfree86/Makefile.am
> @@ -71,7 +71,10 @@ libxorg.c xorg.c:
>
>  DISTCLEANFILES = libxorg.c xorg.c
>
> -Xorg_DEPENDENCIES = libxorg.la
> +Xorg_DEPENDENCIES = libxorg.la \
> +                    $(top_builddir)/dix/libmain.la \
> +                    $(top_builddir)/dix/libdix.la
> +
>  Xorg_LDADD = $(MAIN_LIB) libxorg.la $(XORG_SYS_LIBS) $(XSERVER_SYS_LIBS)

Since libxorg.la already depends on libdix.la (and friends) and
libmain.la == $(MAIN_LIB), I think more appropriate would be:

Xorg_DEPENDENCIES = libxorg.la $(MAIN_LIB)

Updating libdix.la should have already been triggering an update of
Xorg. Or was it not?

--
Dan


More information about the xorg-devel mailing list