[PATCH] Purge macros NEED_EVENTS and NEED_REPLIES

Alan Coopersmith alan.coopersmith at oracle.com
Thu Jul 1 07:05:54 PDT 2010


Fernando Carrijo wrote:
> Thus spake Alan Coopersmith, when questioned about NEED_EVENTS and NEED_REPLIES:
> 
>   "Long long ago,  X was built on  computers with 4Mb RAM. The  amount of memory
>    used for the parse tables was large and if you didn't need it, then you saved
>    time & memory  #ifdef'ing out the bits you didn't  need. Plus, some compilers
>    sucked, life was hard, and the bits  had to be rolled uphill in the snow both
>    ways. In other  words, ancient history that can be  deleted now unless you're
>    really building a 15+ year old release."

And as you found from the discussion last time anyone poked at these:

    The consumer was in past versions of the headers now located
    in proto/x11proto - for instance, in X11R6.0's xc/include/Xproto.h,
    all the event definitions were only available if NEED_EVENTS were
    defined, and all the reply definitions required NEED_REPLIES.

    Looks like Xproto.h dropped them by X11R6.3, which didn't have
    the #ifdef's anymore, so these are truly ancient now.

    <http://www.mail-archive.com/xorg@lists.freedesktop.org/msg02966.html>

For the series:
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list