[PATCH video-xgi] Add Support-ARM, EXA acceleration, EDID, Custom Modes, Bugs fixed, ...

[Gaetan Nadon]

On Mon, 2010-01-25 at 16:29 +0800, Jong Lin wrote:
> This patch includes the following enhancements and some bug fixings.
> 
> (1). Support ARM
> 
> (2). Support EXA acceleration
> 
> (3). Support EDID with I2C function
> 
> (4). Support Custom Modes of modeline
> 
> (5). Unify code for x86, PowerPC, ARM
> 
> 


I used 'git apply --check' to verify the patch would apply but it
doesn't I get errors like:

        error: patch failed: src/init.c:1
        
                error: src/init.c: patch does not apply

The patch shows that the whole content of the init.c file has changed,
but I can't see any real code difference. Then I remembered about code
page issues when translators worked from different platforms (Unix,
Windows...). I checked the file with the 'file' command:


        init.c:        ASCII C program text, with CRLF line terminators
        vb_ext.c:      ASCII C program text
        vb_init.c:     ASCII C program text, with CRLF line terminators
        vb_setmode.c:  ASCII C program text, with CRLF line terminators
        xgi_accel.c:   ASCII C program text, with CRLF line terminators
        xgi_cursor.c:  ASCII C program text
        xgi_dac.c:     ASCII C program text
        xgi_dga.c:     ASCII C program text
        xgi_dri.c:     ASCII C program text
        xgi_driver.c:  ASCII C program text, with CRLF, LF line terminators
        xgi_opt.c:     ASCII C program text
        xgi_setup.c:   ASCII C program text, with CRLF, LF line terminators
        xgi_vb.c:      ASCII C program text
        xgi_vga.c:     ASCII C program text, with CRLF line terminators
        xgi_video.c:   ASCII C program text
        xgi_videohw.c: ASCII C program text
        

It just so happens that the files giving errors are the one with CRLF
terminators. Most likely, xgi developers edit code on platforms having
different file formats. I did a quick scan on other drivers and I have
not seen files with CRLF terminators.

It's just a theory for now, most likely others have seen this before and
know of to fix it.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20100125/a7b00217/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20100125/a7b00217/attachment.pgp