[PATCH inputproto] Define the error cases for XSetDeviceMode better.

Fernando Carrijo fcarrijo at yahoo.com.br
Tue Jan 12 04:01:18 PST 2010


On Tue, 12 Jan 2010 11:45:16 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> Take the error codes as described in the man page for XSetDeviceMode. This
> is more likely to be what clients expect, especially since the protocol spec
> doesn't actually define when BadMode is to be reported.
> 
> This behaviour is the same as specified in the XSetDeviceMode man page.

Reviewed-by: Fernando Carrijo <fcarrijo at yahoo.com.br>

> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  XIproto.txt |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/XIproto.txt b/XIproto.txt
> index 20cc02a..f9d19f0 100644
> --- a/XIproto.txt
> +++ b/XIproto.txt
> @@ -577,7 +577,9 @@
>     already has the device open with a different mode. It will fail
>     and return AlreadyGrabbed if another client has the device
>     grabbed. The request will fail with a BadMatch error if the
> -   requested mode is not supported by the device.
> +   device has no valuators and reports no axes of motion. The
> +   request will fail with a BadMode error if the requested mode
> +   is not supported by the device.
>  
>                         SetDeviceMode
>                                 device:DEVICE
> -- 
> 1.6.6
> 
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel
> 



More information about the xorg-devel mailing list