[PATCH] libX11: Fix comment: Invert polarity (direction) of reformat description.

Alan Coopersmith Alan.Coopersmith at Sun.COM
Mon Jan 11 20:56:44 PST 2010


Thanks for the patch, I've gone ahead and pushed it.   I did strip
the comments ("First patch...") from the body of the git commit -
when sending git patches, you can put comments that you don't intend
to go into the actual commit message after the --- line (i.e. in the
section with the diffstats).

	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering

Thien-Thi Nguyen wrote:
> First patch!  I hope it is uncontronversial, but
> welcome feedback on how to improve it in any case.
> 
> thi
> 
> 
> Signed-off-by: Thien-Thi Nguyen <ttn at gnuvola.org>
> ---
>  src/EvToWire.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/src/EvToWire.c b/src/EvToWire.c
> index 124fb74..b4d7c2b 100644
> --- a/src/EvToWire.c
> +++ b/src/EvToWire.c
> @@ -42,13 +42,15 @@ from The Open Group.
>  #include "Xlibint.h"
>  
>  /*
> - * reformat a wire event into an XEvent structure of the right type.
> + * Reformat an XEvent structure to a wire event of the right type.
> + * Return True on success.  If the type is unrecognized, return what
> + * _XUnknownNativeEvent returns (i.e., False).
>   */
>  Status
>  _XEventToWire(
> -register Display *dpy,	/* pointer to display structure */
> -register XEvent *re,	/* pointer to where event should be reformatted */
> -register xEvent *event)	/* wire protocol event */
> +    register Display *dpy,
> +    register XEvent *re,        /* in: from */
> +    register xEvent *event)     /* out: to */
>  {
>  	switch (event->u.u.type = re->type) {
>  	      case KeyPress:




More information about the xorg-devel mailing list