[PATCH xserver] configure: use backticks rather than $() for commands

Gaetan Nadon memsize at videotron.ca
Fri Jan 8 16:14:16 PST 2010


Using git send-email, the CC to "Keith Packard <keithp at keithp.com>" did
not work. I used the same command to send a patch to the list and CC
Alan and it did work. Maybe someone had this problem before.

I am resending the patch that has been reviewed, with the review tags. 

The log:
RCPT TO:<xorg-devel at lists.x.org>,<keithp at keithp.com>
From: Gaetan Nadon <memsize at videotron.ca>
To: "X.Org Development" <xorg-devel at lists.x.org>
Cc: Keith Packard <keithp at keithp.com>
Subject: [PATCH xserver] configure: use backticks rather than $() for
commands
Date: Fri,  8 Jan 2010 19:04:25 -0500



On Fri, 2010-01-08 at 19:04 -0500, Gaetan Nadon wrote:

> This patch to xserver configure.ac is to increase code portability to
> non POSIX system by using backticks rather than $() for command
> substitution for BUILD_DATE and BUILD_TIME.
> 
> Reviewed-by: Rémi Cardona <remi at gentoo.org>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index e0ddd48..92dd8a4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2112,9 +2112,9 @@ AC_TRY_COMPILE([
>  
>  AC_DEFINE_DIR(PROJECTROOT, prefix, [Overall prefix])
>  
> -BUILD_DATE="$(date +'%Y%m%d')"
> +BUILD_DATE="`date +'%Y%m%d'`"
>  AC_SUBST([BUILD_DATE])
> -BUILD_TIME="$(date +'1%H%M%S')"
> +BUILD_TIME="`date +'1%H%M%S'`"
>  AC_SUBST([BUILD_TIME])
>  
>  DIX_CFLAGS="-DHAVE_DIX_CONFIG_H $XSERVER_CFLAGS"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20100108/f02d621b/attachment.html 


More information about the xorg-devel mailing list