libXrandr Status return value confusion

Michel Dänzer michel at daenzer.net
Thu Jan 7 07:44:52 PST 2010


On Thu, 2010-01-07 at 16:07 +0100, Matthias Hopf wrote: 
> On Jan 05, 10 20:20:52 +0100, Michel Dänzer wrote:
> > 
> > There seems to be some confusion in libXrandr as to what a Status return
> > value is supposed to mean. Some functions just return rep.status (so 0
> > means success, non-0 failure), others return True (non-0, success) or
> > False (0, failure).
> > 
> > Could the return value of the functions returning True/False be changed
> > to Bool without breaking ABI? Any other ideas for cleaning this up?
> 
> Those functions I found to return rep.status have the type Status
> already.

Sure, the problem is functions which declare a Status (Success/...)
return value but effectively return a Bool (False/True) value.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list