[PATCH] set_fontset_extents crash after get_rotate_fontname fix in 2bef065b70f7

Adam Jackson ajax at nwnk.net
Wed Jan 6 07:40:59 PST 2010


On Tue, 2010-01-05 at 17:34 -0800, Alan Coopersmith wrote:
> From: Osamu Sayama <osamu.sayama at sun.com>
> 
> - In set_fontset_extents, check font_data is not NULL before running
>   loop that may increment it to a non-NULL invalid pointer.
> - Make sure get_rotate_fontname counts the final field
> 
> Fixes OpenSolaris bug 6913809: X application dumps core in ja_JP.UTF-8 locale
> <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6913809>
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>

Lame that a font might have non-zero vrotate_num but null vrotate, but
we certainly shouldn't crash on bad fonts.

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20100106/0599995e/attachment.pgp 


More information about the xorg-devel mailing list